Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Account functionality #137

Closed
einar-lanfranco opened this issue Dec 19, 2023 · 7 comments
Closed

Service Account functionality #137

einar-lanfranco opened this issue Dec 19, 2023 · 7 comments

Comments

@einar-lanfranco
Copy link
Contributor

I develop some functions i need, its a parcial functionality but i could make a pull request if you want to.

I use this fork https://github.com/einar-lanfranco/grafana-client

@amotl
Copy link
Contributor

amotl commented Dec 23, 2023

Dear Einar,

thank you for writing in, and for working on supporting Service Accounts. Your contribution will be much appreciated.

With kind regards,
Andreas.

@einar-lanfranco
Copy link
Contributor Author

PR Done! :D

@amotl
Copy link
Contributor

amotl commented Jan 8, 2024

Dear @einar-lanfranco and @feerbau,

GH-139 has been merged, and grafana-client 3.11.0 has just been released, including your improvement. Thank you again.

What is yet missing, is the wrapper for Update service account. Maybe you can add it on behalf of a subsequent patch, including a corresponding test case?

With kind regards,
Andreas.

@amotl
Copy link
Contributor

amotl commented Mar 29, 2024

What is yet missing, is the wrapper for Update service account.

There is a patch now, which improves the situation.

@amotl
Copy link
Contributor

amotl commented Mar 29, 2024

Corresponding enhancements have been included in grafana-client 4.0.0. Please let us know if they improve the situation for you.

@chintal
Copy link
Collaborator

chintal commented Apr 22, 2024

I've used service accounts in 4.0+. No noticeable issues.

@amotl
Copy link
Contributor

amotl commented Apr 22, 2024

Thank you. Closing.

@amotl amotl closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants