From b0512fddfde506752a628a1318db79cf3fdbce2c Mon Sep 17 00:00:00 2001
From: 0penBrain <48731257+0penBrain@users.noreply.github.com>
Date: Sun, 8 Oct 2023 09:58:34 +0200
Subject: [PATCH] Refactor bookmarks save using range-based for loops

---
 src/qtgui/bookmarks.cpp | 37 ++++++++++++++++---------------------
 1 file changed, 16 insertions(+), 21 deletions(-)

diff --git a/src/qtgui/bookmarks.cpp b/src/qtgui/bookmarks.cpp
index 8dd179a0af..aa8f60acef 100644
--- a/src/qtgui/bookmarks.cpp
+++ b/src/qtgui/bookmarks.cpp
@@ -167,20 +167,19 @@ bool Bookmarks::save()
         stream << QString("# Tag name").leftJustified(20) + "; " +
                   QString(" color") << '\n';
 
-        QMap<QString, TagInfo::sptr> usedTags;
-        for (int iBookmark = 0; iBookmark < m_BookmarkList.size(); iBookmark++)
+        std::map<QString, TagInfo::sptr> usedTags;
+        for (const auto &bookmarkInfo: m_BookmarkList)
         {
-            BookmarkInfo& info = m_BookmarkList[iBookmark];
-            for (QList<TagInfo::sptr>::iterator iTag = info.tags.begin(); iTag < info.tags.end(); ++iTag)
+            for (const auto &tag: bookmarkInfo.tags)
             {
-              usedTags.insert((*iTag)->name, *iTag);
+              usedTags.emplace(tag->name, tag);
             }
         }
 
-        for (QMap<QString, TagInfo::sptr>::iterator i = usedTags.begin(); i != usedTags.end(); i++)
+        for (const auto &tag: usedTags)
         {
-            TagInfo::sptr info = *i;
-            stream << saveEncoded(info->name).leftJustified(20) + "; " + info->color.name() << '\n';
+            auto tagInfo = tag.second;
+            stream << saveEncoded(tagInfo->name).leftJustified(20) + "; " + tagInfo->color.name() << '\n';
         }
 
         stream << '\n';
@@ -191,22 +190,18 @@ bool Bookmarks::save()
                   QString("Bandwidth").rightJustified(10) + "; " +
                   QString("Tags") << '\n';
 
-        for (int i = 0; i < m_BookmarkList.size(); i++)
+        for (const auto &bookmarkInfo: m_BookmarkList)
         {
-            BookmarkInfo& info = m_BookmarkList[i];
-            QString line = QString::number(info.frequency).rightJustified(12) +
-                    "; " + saveEncoded(info.name).leftJustified(25) + "; " +
-                    info.modulation.leftJustified(20)+ "; " +
-                    QString::number(info.bandwidth).rightJustified(10) + "; ";
-            for(int iTag = 0; iTag<info.tags.size(); ++iTag)
+            QString line = QString::number(bookmarkInfo.frequency).rightJustified(12) +
+                    "; " + saveEncoded(bookmarkInfo.name).leftJustified(25) + "; " +
+                    bookmarkInfo.modulation.leftJustified(20)+ "; " +
+                    QString::number(bookmarkInfo.bandwidth).rightJustified(10) + "; ";
+            QStringList tags;
+            for(const auto &tagInfo: bookmarkInfo.tags)
             {
-                TagInfo::sptr tag = info.tags[iTag];
-                if (iTag!=0)
-                {
-                    line.append(",");
-                }
-                line.append(saveEncoded(tag->name));
+                tags.append(saveEncoded(tagInfo->name));
             }
+            line.append(tags.join(','));
 
             stream << line << '\n';
         }