Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Uncompressed Data #66

Open
dukesook opened this issue Sep 5, 2023 · 2 comments
Open

Validate Uncompressed Data #66

dukesook opened this issue Sep 5, 2023 · 2 comments

Comments

@dukesook
Copy link
Contributor

dukesook commented Sep 5, 2023

I'm interested in having the Compliance Warden verify uncompressed data as per 23001-17.

Perhaps this warrants a new uncompressed.cpp file with its own SpecDesc object. I imagine it would depend on the heif spec, but 23001-17 can also apply to mp4 files.

Any thoughts?

@rbouqueau
Copy link
Member

That would be great!

The first thing is to work on a new branch. Submit a pull request.

it would depend on the heif spec, but 23001-17 can also apply to mp4 files.

The dependency on heif can already be expressed. I am not familiar enough with the 23001-17 spec. If some rules are common to uncompressed items and tracks, you can store them in a std::vector<RuleDesc> and add it to the SpecDesc.rules member.

The list of rules can be inferred from the normative statements (SHALL, SHOULD...). Do you have such a list?

An important part is to provide both positive and negative test vectors. I can certainly help transform a sample into a NASM assembly file for further editing.

@dukesook
Copy link
Contributor Author

dukesook commented Sep 6, 2023

I don't have a list of rules, but they are explicit in the the 23011-17 document itself by searching the terms SHALL and SHOULD.

Yes, I can intentionally create non-compliant uncompressed files simply to test the new rules in the SpecDesc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants