Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed exposure names and added labels #172

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fixed exposure names and added labels #172

merged 3 commits into from
Aug 3, 2023

Conversation

mcnick
Copy link
Contributor

@mcnick mcnick commented Aug 1, 2023 •
edited
Loading

Problem

#168 Since dbt 1.3 exposure names containing other characters than letters, numbers, underscores and hyphens are deprecated

Changes

  • Replaced all characters not being letters, numbers or hyphens by underscores in the exposure name
  • Added the original card name as exposure label

gouline
gouline reviewed Aug 2, 2023
View reviewed changes
dbtmetabase/metabase.py Outdated Show resolved Hide resolved
@gouline gouline merged commit abf5517 into gouline:master Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouline gouline gouline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcnick @gouline