Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteMessage and WriteControl do not check error from SetWriteDeadline [bug] #705

Open
rittneje opened this issue Jun 28, 2021 · 1 comment
Open

WriteMessage and WriteControl do not check error from SetWriteDeadline [bug] #705

rittneje opened this issue Jun 28, 2021 · 1 comment
Labels
bug

Comments

@rittneje
Copy link

The SetWriteDeadline method from net.Conn can return an error. https://golang.org/pkg/net/#Conn

However, this library neglects to check it.

websocket/conn.go

Line 389 in b65e629

c.conn.SetWriteDeadline(deadline)

websocket/conn.go

Line 456 in b65e629

c.conn.SetWriteDeadline(deadline)

@rittneje rittneje added the bug label Jun 28, 2021
kevinlincg added a commit to kevinlincg/websocket that referenced this issue Jan 24, 2022
@kevinlincg
fix gorilla#705
99ada6e 
Remove writeDealine , use net/Conn SetWriteDeadline and handle error to user.
@kevinlincg kevinlincg mentioned this issue Jan 24, 2022
Closed
@hulkingshtick
Copy link

This is fixed. I searched the code and cannot find any calls that ignore errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Gorilla Web Toolkit
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #705 kevinlincg/websocket
4 participants
@garyburd @coreydaley @rittneje @hulkingshtick