You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on my understanding and testing, it appears that the variable should actually contain Host values (e.g., github.com) rather than full Origin values (e.g., https://github.com).
This distinction was not immediately clear from the documentation or the code comments (This is stated in the only README).
Expected Behavior
To avoid potential confusion, would it be possible to consider renaming the variable to something more indicative of its intended content, such as TrustedHosts?
If renaming is not feasible for backward compatibility, perhaps adding a more explicit explanation or comment in the code to clarify the expected format of values could be helpful.
Is there an existing issue for this?
Current Behavior
Based on my understanding and testing, it appears that the variable should actually contain Host values (e.g., github.com) rather than full Origin values (e.g., https://github.com).
csrf/csrf.go
Lines 261 to 262 in a009743
This distinction was not immediately clear from the documentation or the code comments (This is stated in the only README).
Expected Behavior
To avoid potential confusion, would it be possible to consider renaming the variable to something more indicative of its intended content, such as TrustedHosts?
If renaming is not feasible for backward compatibility, perhaps adding a more explicit explanation or comment in the code to clarify the expected format of values could be helpful.
csrf/options.go
Lines 123 to 128 in a009743
Steps To Reproduce
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: