Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to gophercloud v2.0.0-beta.1 + CI Hygiene #199

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Feb 9, 2024

Bump Gophercloud to v2.0.0-beta.1

@EmilienM EmilienM changed the title Bump to gophercloud v2 beta.1 Bump to gophercloud v2.0.0-beta.1 Feb 9, 2024
@pierreprinetti
Copy link
Contributor

What do you think about changing the module name in go.mod to github.com/gophercloud/utils/v2? So that the two versions are independently usable

@EmilienM EmilienM changed the title Bump to gophercloud v2.0.0-beta.1 Bump to gophercloud v2.0.0-beta.1 + CI Hygiene Feb 9, 2024
@EmilienM
Copy link
Contributor Author

EmilienM commented Feb 9, 2024

ping @gophercloud/core

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we start vendoring?

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, rather than deleting the acceptance tests, shouldn't we try to setup jobs like we did for the gophercloud repo?

We never had a CI job that executed these acceptance tests.
We don't have the resources to maintain them, therefore, we remove them.
@EmilienM
Copy link
Contributor Author

EmilienM commented Feb 9, 2024

I removed vendoring, but I won't do acceptance, really not worth it IMO.

@EmilienM EmilienM requested a review from mandre February 9, 2024 19:56
@EmilienM
Copy link
Contributor Author

Acceptance tests can be re-added later if that's a blocker for the reviewer. They don't run today anyway.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a v2 of utils for people to consume gophercloud v2. Let's not block for the deleted acceptance tests.

LGTM.

@mandre mandre merged commit c8cd627 into gophercloud:master Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants