-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to gophercloud v2.0.0-beta.1 + CI Hygiene #199
Conversation
825e97a
to
07f5658
Compare
What do you think about changing the module name in go.mod to |
5449592
to
54c8b9c
Compare
ping @gophercloud/core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we start vendoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, rather than deleting the acceptance tests, shouldn't we try to setup jobs like we did for the gophercloud repo?
We never had a CI job that executed these acceptance tests. We don't have the resources to maintain them, therefore, we remove them.
I removed vendoring, but I won't do acceptance, really not worth it IMO. |
Acceptance tests can be re-added later if that's a blocker for the reviewer. They don't run today anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a v2 of utils for people to consume gophercloud v2. Let's not block for the deleted acceptance tests.
LGTM.
Bump Gophercloud to v2.0.0-beta.1