Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of dependencies #723

Closed
michelseiler opened this issue Apr 25, 2024 · 3 comments
Closed

Get rid of dependencies #723

michelseiler opened this issue Apr 25, 2024 · 3 comments

Comments

@michelseiler
Copy link

It would be nice if this package reduce the dependencies.

Package github.com/pkg/errors is used in errors/errors.go:

  • pkg_errors.Errorf(Prefix+format, a...) could be replaced with fmt.Errorf(Prefix+format, a...)
  • pkg_errors.New(Prefix + text) could be replaced with fmt.Errorf(Prefix + text)

Package golang.org/x/exp is used in client_sub.go and debug/debug.go for slices:

  • It could perhaps be replaced by the standard library function slices.Contains() when Bumping GO version to 1.21.
@michelseiler
Copy link
Author

Thanks!
Should i write another issue for the golang.org/x/exp package since this is not resolved by PR #731?

@kung-foo
Copy link
Member

As I wrote (just now) in #721, we are going to hold at Go 1.20 due to compatibility issues which means the slices.Contains generic function isn't available.

@michelseiler
Copy link
Author

Thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants