-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add instructions on how to update embedded ots #3
Comments
could we have a "meta" check that ensures the locally installed version of the python-ots version is the latest available and, if not, emit a ERROR instructing the user on how to perform the update? |
No, I don't think you need that. You just need to bump the minimum required version of opentype-sanitizer in fontbakery's setup.py |
basically, you just treat opentype-sanitizer as yet another python dependency. |
great! So the only remaining concern would be to ensure fontbakery itself is always up-to-date, thus, fonttools/fontbakery#2093 |
yea. this issue is more about reducing the "bus factor" and allow others besides me to keep this repository in sync with the upstream ots repo's release schedule |
@anthrotype, it is not clear what went wrong here: |
Trying to fix issue while installing cryptography (dependency of twine) https://travis-ci.org/github/googlefonts/ots-python/jobs/771724661#L662 #3 (comment)
@felipesanches Thanks Felipe. It looks like installing twine failed on Linux because pip was too old (it tried to build cryptography package from source and failed, but a more recent pip would download the pre-compiled wheel for cryptography and not fail). I fixed that in faf8c06 and tagged https://github.com/googlefonts/ots-python/releases/tag/v8.1.4.post1 At some point we should also move this from Travis to Github Actions. Maybe @m4rc1e can help with that |
Trying to fix issue while installing cryptography (dependency of twine) https://travis-ci.org/github/googlefonts/ots-python/jobs/771724661#L662 #3 (comment)
Ops.. It looks like a pushed that commit and v8.1.4.post1 tag to the wrong branch "master" instead of "main" so that release is actually missing the new 8.1.4 ots 😅 |
I just added @felipesanches as co-maintainer to the opentype-sanitizer PyPI account, in case you ever need to delete or "yank" bad releases (like I had to do for the .post1 with the wrong embedded OTS) |
cool! Thanks! :-D |
... when a new version is released upstream.
It should be as easy as changing the "version" and "sha256" values in
setup.cfg
file:ots-python/setup.cfg
Lines 1 to 6 in dc1c925
commit that change, create a git tag with the same version number (always keep a leading
v
, e.g.v7.1.9
in the git tag name), and push the tag. The bots will do the rest.The text was updated successfully, but these errors were encountered: