Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions on how to update embedded ots #3

Open
anthrotype opened this issue Oct 16, 2018 · 10 comments
Open

add instructions on how to update embedded ots #3

anthrotype opened this issue Oct 16, 2018 · 10 comments

Comments

@anthrotype
Copy link
Member

... when a new version is released upstream.

It should be as easy as changing the "version" and "sha256" values in setup.cfg file:

ots-python/setup.cfg

Lines 1 to 6 in dc1c925

[download]
; OpenType Sanitizer version that is downloaded from setup.py
version = 7.1.8
; expected SHA-256 of the downloaded tarball. E.g. you can calculate it with:
; $ shasum -a 256 ots-X.X.X.tar.xz
sha256 = 7e0e3233e7cb07073a48d48fbfccf7a09b1b68fdd60189213c0cf76f59bd2bec

commit that change, create a git tag with the same version number (always keep a leading v, e.g. v7.1.9 in the git tag name), and push the tag. The bots will do the rest.

@felipesanches
Copy link
Member

could we have a "meta" check that ensures the locally installed version of the python-ots version is the latest available and, if not, emit a ERROR instructing the user on how to perform the update?

@anthrotype
Copy link
Member Author

No, I don't think you need that. You just need to bump the minimum required version of opentype-sanitizer in fontbakery's setup.py install_requires, and released updated fontbakery whenever opentype-sanitizer is updated.
That will ensure that whenever fontbakery is updated, the latest version of opentype-sanitizer will also be used.

@anthrotype
Copy link
Member Author

basically, you just treat opentype-sanitizer as yet another python dependency.

@felipesanches
Copy link
Member

great! So the only remaining concern would be to ensure fontbakery itself is always up-to-date, thus, fonttools/fontbakery#2093

@anthrotype
Copy link
Member Author

yea. this issue is more about reducing the "bus factor" and allow others besides me to keep this repository in sync with the upstream ots repo's release schedule

@felipesanches
Copy link
Member

@anthrotype, it is not clear what went wrong here:
https://travis-ci.org/github/googlefonts/ots-python/jobs/771724661

anthrotype added a commit that referenced this issue May 20, 2021
@anthrotype
Copy link
Member Author

@felipesanches Thanks Felipe. It looks like installing twine failed on Linux because pip was too old (it tried to build cryptography package from source and failed, but a more recent pip would download the pre-compiled wheel for cryptography and not fail). I fixed that in faf8c06 and tagged https://github.com/googlefonts/ots-python/releases/tag/v8.1.4.post1

At some point we should also move this from Travis to Github Actions. Maybe @m4rc1e can help with that

anthrotype added a commit that referenced this issue May 20, 2021
@anthrotype
Copy link
Member Author

Ops.. It looks like a pushed that commit and v8.1.4.post1 tag to the wrong branch "master" instead of "main" so that release is actually missing the new 8.1.4 ots 😅
I immediately pushed a new v8.1.4.post2 release from the correct branch, apologies

@anthrotype
Copy link
Member Author

I just added @felipesanches as co-maintainer to the opentype-sanitizer PyPI account, in case you ever need to delete or "yank" bad releases (like I had to do for the .post1 with the wrong embedded OTS)

@felipesanches
Copy link
Member

cool! Thanks! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants