Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-nonhinting] Changing maxp maxSizeOfInstructions when adding prep table #912

Open
kalapi opened this issue Apr 5, 2024 · 1 comment

Comments

@kalapi
Copy link
Contributor

kalapi commented Apr 5, 2024

Hello!

I'd like to preface this by saying that i'm unsure whether or not this needs to be implemented/fixed, but since the maxp table handles memory requirements I was thinking that it might be important to get right.

Issue description

When I run gftools fix-unhinted a prep table is added to the font but the maxSizeOfInstructions remains unchanged. The prep table generated for me has 7 lines(bytes) of instructions and thus this should reflect in the maxp table

Interested to know your thoughts and thanks in advance for your help!

@simoncozens
Copy link
Contributor

the maxp table handles memory requirements

Does it, though? :-) I mean, historically, perhaps. But these days I don't know if any TrueType implementations are going to barf because the maxSizeOfInstructions is wrong. Worth noting that font["maxp"].recalc() in fontTools computes everything apart from the maxSizeOfInstructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants