Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder doesn't flatten nested components #346

Closed
alexeiva opened this issue Mar 16, 2021 · 2 comments
Closed

builder doesn't flatten nested components #346

alexeiva opened this issue Mar 16, 2021 · 2 comments

Comments

@alexeiva
Copy link
Contributor

I am working on a private repo with a builder workflow, and have some nested components.
I added a flattenComponents: true to config.yaml (but it should be on by default).
Fontbakery still gives me the nested components fail:

 * FAIL: The following glyphs have components which themselves are component glyphs:
	* uni1EB0
	* uni1EB4
	* uni1EAA
	* uni01C4
	* uni01C5
	* uni1EC4
	* uni01C8
	* uni01CB
	* uni1ED6
	* aacute and 196 more. [code: found-nested-components]

I tried to manually add a ufo2ft filter to the UFOs in master_ufo to unnest composites as described in fonttools/fontbakery#2961 (comment)
The generated fonts via fontmake then decompose correctly.

It looks like the flattenComponents filter isn't working with builder.

Reference:
https://github.com/googlefonts/youtube-sans/issues/12#issuecomment-800033139

@m4rc1e
Copy link
Collaborator

m4rc1e commented Mar 17, 2021

Have you upgraded your gftools? pip install --upgrade gftools

@alexeiva
Copy link
Contributor Author

upgrading fonttools fixed the issue. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants