New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add options.logging in cloud build trigger configs #3342

Merged

mpeddada1 merged 1 commit into main from fix-logging-error

Nov 7, 2024

+10 −1

Contributor

mpeddada1 commented Nov 7, 2024

Emulating solution in googleapis/java-shared-config#921 to address the following error:

generic::invalid_argument: if 'build.service_account' is specified, the build must either (a) specify 'build.logs_bucket', (b) use the REGIONAL_USER_OWNED_BUCKET build.options.default_logs_bucket_behavior option, or (c) use either CLOUD_LOGGING_ONLY / NONE logging options


          chore: add options.logging in cloud build trigger configs

79d3cd6

mpeddada1 requested a review from JoeWang1127

November 7, 2024 00:06

product-auto-label bot added the size: s label

sonarcloud bot commented Nov 7, 2024

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Nov 7, 2024

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JoeWang1127 approved these changes

View reviewed changes

mpeddada1 merged commit a1db8b7 into main

51 of 55 checks passed

mpeddada1 deleted the fix-logging-error branch

November 7, 2024 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s