Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add additional potential exceptions when retrieving protobuf manifest file to get version #3315

Merged
merged 4 commits into from
Oct 25, 2024
Merged

fix: add additional potential exceptions when retrieving protobuf manifest file to get version #3315

merged 4 commits into from
Oct 25, 2024
+1 −2

Conversation

ldetmer
Copy link
Contributor

@ldetmer ldetmer commented Oct 25, 2024 •
edited
Loading

#3314 3314

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Oct 25, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

burkedavison
burkedavison reviewed Oct 25, 2024
View reviewed changes
gax-java/gax/src/main/java/com/google/api/gax/core/GaxProperties.java Outdated
| IOException
| IllegalArgumentException
| SecurityException
| NullPointerException e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just catch Exception? Is there any Exception that we would want to propagate from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we should safely ignore this as it doesn't block runtime.

@ldetmer ldetmer enabled auto-merge (squash) October 25, 2024 17:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ldetmer ldetmer merged commit ef9e518 into main Oct 25, 2024
48 of 49 checks passed
@ldetmer ldetmer deleted the fix-getting-protobuf-exception branch October 25, 2024 17:18
@release-please release-please bot mentioned this pull request Oct 25, 2024
Merged
mpeddada1 pushed a commit that referenced this pull request Oct 25, 2024
@release-please
chore(main): release 2.49.0 (#3312)
9332326 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.49.0</summary>

##
[2.49.0](v2.48.0...v2.49.0)
(2024-10-25)


### Features

* Move release note generation to a sub module
([#3299](#3299))
([7d6d66a](7d6d66a))


### Bug Fixes

* add additional potential exceptions when retrieving protobuf manifest
file to get version
([#3315](#3315))
([ef9e518](ef9e518))


### Dependencies

* update dependency com.google.errorprone:error_prone_annotations to
v2.35.1
([#3316](#3316))
([d7c290f](d7c290f))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

@lqiu96 lqiu96 Awaiting requested review from lqiu96

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldetmer @blakeli0 @burkedavison