-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate java tests #3227
Conversation
@@ -18,7 +18,7 @@ on: | |||
schedule: | |||
- cron: '0 2 * * *' | |||
workflow_dispatch: | |||
|
|||
{% raw %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to render ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
, use raw
to ignore the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file still used in unit tests? Same question for all other test files like sponge-log-golden.xml
. I don't see them being used so they should've probably be removed from synthtool long time ago. Can we only keep the ones used in unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
I removed unused test resources.
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
In this PR:
test_language_java.py
and test resources from synthtool.java.py
.