Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing unit tests in PathTemplateTest #2823

Merged
merged 1 commit into from
May 28, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented May 27, 2024

Fix #2776 and #2778.

The failing tests are in the same file, thus combine into one pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 27, 2024
@JoeWang1127 JoeWang1127 changed the title chore: fix failing unit tests chore: fix failing unit tests in PathTemplateTest May 27, 2024
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 27, 2024 21:35
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 27, 2024 21:35
@JoeWang1127 JoeWang1127 merged commit 0442df6 into main May 28, 2024
46 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/refactor-test branch May 28, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
2 participants