fix: opentelemetry-bom to be in third-party-dependencies BOM #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing opentelemetry-bom in gapic-generator-java-bom wrongly implies that we (Google) publish the OpenTelemetry artifacts. https://jlbp.dev/JLBP-15 states: Your project's BOM should not include any of your dependencies on other libraries. In this change, the opentelemetry-bom is declared in the third- party-dependencies BOM and thus will be excluded in the Google Cloud Libraries BOM.
|
|
meltsufin
approved these changes
May 6, 2024
JoeWang1127
added a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>2.40.1</summary> ## [2.40.1](v2.40.0...v2.40.1) (2024-05-15) ### Bug Fixes * [common-protos] An existing method `UpdateVehicleLocation` is ([7f96074](7f96074)) * [common-protos] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2751](#2751)) ([7f96074](7f96074)) * [iam] An existing method `UpdateVehicleLocation` is removed from ([4a1ae7b](4a1ae7b)) * [iam] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2752](#2752)) ([4a1ae7b](4a1ae7b)) * do not populate repo level change while removing library ([#2740](#2740)) ([43e62b9](43e62b9)) * only append `.api.grpc` suffix to group id if the artifact id starts with `proto-` or `grpc-` ([#2731](#2731)) ([8e87b2e](8e87b2e)) * opentelemetry-bom to be in third-party-dependencies BOM ([#2736](#2736)) ([4ecc89b](4ecc89b)) * prepare to generate grafeas ([#2761](#2761)) ([1114f18](1114f18)) * Replace deprecated protobuf methods. ([#2764](#2764)) ([986c090](986c090)) ### Dependencies * update dependency black to v24.4.2 ([#2660](#2660)) ([1cbb681](1cbb681)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 ([#2732](#2732)) ([891b01d](891b01d)) * update dependency com.google.cloud:grpc-gcp to v1.6.0 ([#2767](#2767)) ([a39aa07](a39aa07)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2708](#2708)) ([4d7d246](4d7d246)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2709](#2709)) ([4e31d7d](4e31d7d)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.36.0 ([#2768](#2768)) ([22b7398](22b7398)) * update dependency commons-codec:commons-codec to v1.17.0 ([#2710](#2710)) ([b87356c](b87356c)) * update dependency jinja2 to v3.1.4 [security] ([#2742](#2742)) ([d67eaf8](d67eaf8)) * update dependency lxml to v5.2.2 ([#2766](#2766)) ([df7e211](df7e211)) * update dependency markupsafe to v2.1.5 ([#2657](#2657)) ([805baf8](805baf8)) * update dependency net.bytebuddy:byte-buddy to v1.14.15 ([#2753](#2753)) ([a472620](a472620)) * update dependency platformdirs to v4.2.1 ([#2662](#2662)) ([dbdcc91](dbdcc91)) * update googleapis/java-cloud-bom digest to db4265f ([#2755](#2755)) ([908db6f](908db6f)) * update googleapis/java-cloud-bom digest to f3c611a ([#2700](#2700)) ([d254e9b](d254e9b)) * update opentelemetry-java monorepo to v1.38.0 ([#2769](#2769)) ([0a5c7c4](0a5c7c4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <[email protected]>
lqiu96
pushed a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>2.40.1</summary> ## [2.40.1](v2.40.0...v2.40.1) (2024-05-15) ### Bug Fixes * [common-protos] An existing method `UpdateVehicleLocation` is ([7f96074](7f96074)) * [common-protos] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2751](#2751)) ([7f96074](7f96074)) * [iam] An existing method `UpdateVehicleLocation` is removed from ([4a1ae7b](4a1ae7b)) * [iam] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2752](#2752)) ([4a1ae7b](4a1ae7b)) * do not populate repo level change while removing library ([#2740](#2740)) ([43e62b9](43e62b9)) * only append `.api.grpc` suffix to group id if the artifact id starts with `proto-` or `grpc-` ([#2731](#2731)) ([8e87b2e](8e87b2e)) * opentelemetry-bom to be in third-party-dependencies BOM ([#2736](#2736)) ([4ecc89b](4ecc89b)) * prepare to generate grafeas ([#2761](#2761)) ([1114f18](1114f18)) * Replace deprecated protobuf methods. ([#2764](#2764)) ([986c090](986c090)) ### Dependencies * update dependency black to v24.4.2 ([#2660](#2660)) ([1cbb681](1cbb681)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 ([#2732](#2732)) ([891b01d](891b01d)) * update dependency com.google.cloud:grpc-gcp to v1.6.0 ([#2767](#2767)) ([a39aa07](a39aa07)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2708](#2708)) ([4d7d246](4d7d246)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2709](#2709)) ([4e31d7d](4e31d7d)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.36.0 ([#2768](#2768)) ([22b7398](22b7398)) * update dependency commons-codec:commons-codec to v1.17.0 ([#2710](#2710)) ([b87356c](b87356c)) * update dependency jinja2 to v3.1.4 [security] ([#2742](#2742)) ([d67eaf8](d67eaf8)) * update dependency lxml to v5.2.2 ([#2766](#2766)) ([df7e211](df7e211)) * update dependency markupsafe to v2.1.5 ([#2657](#2657)) ([805baf8](805baf8)) * update dependency net.bytebuddy:byte-buddy to v1.14.15 ([#2753](#2753)) ([a472620](a472620)) * update dependency platformdirs to v4.2.1 ([#2662](#2662)) ([dbdcc91](dbdcc91)) * update googleapis/java-cloud-bom digest to db4265f ([#2755](#2755)) ([908db6f](908db6f)) * update googleapis/java-cloud-bom digest to f3c611a ([#2700](#2700)) ([d254e9b](d254e9b)) * update opentelemetry-java monorepo to v1.38.0 ([#2769](#2769)) ([0a5c7c4](0a5c7c4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <[email protected]>
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
Importing opentelemetry-bom in gapic-generator-java-bom (and thus Google Cloud Libraries BOM) wrongly implies that we (Google) publish the OpenTelemetry artifacts. https://jlbp.dev/JLBP-15 states: > Your project's BOM should not include any of your dependencies on other libraries. In this change, the opentelemetry-bom is declared in the third-party-dependencies BOM and thus will be excluded in the Google Cloud Libraries BOM, which does not import the third-party-dependencies BOM. Related to b/338624813
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>2.40.1</summary> ## [2.40.1](v2.40.0...v2.40.1) (2024-05-15) ### Bug Fixes * [common-protos] An existing method `UpdateVehicleLocation` is ([7f96074](7f96074)) * [common-protos] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2751](#2751)) ([7f96074](7f96074)) * [iam] An existing method `UpdateVehicleLocation` is removed from ([4a1ae7b](4a1ae7b)) * [iam] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2752](#2752)) ([4a1ae7b](4a1ae7b)) * do not populate repo level change while removing library ([#2740](#2740)) ([43e62b9](43e62b9)) * only append `.api.grpc` suffix to group id if the artifact id starts with `proto-` or `grpc-` ([#2731](#2731)) ([8e87b2e](8e87b2e)) * opentelemetry-bom to be in third-party-dependencies BOM ([#2736](#2736)) ([4ecc89b](4ecc89b)) * prepare to generate grafeas ([#2761](#2761)) ([1114f18](1114f18)) * Replace deprecated protobuf methods. ([#2764](#2764)) ([986c090](986c090)) ### Dependencies * update dependency black to v24.4.2 ([#2660](#2660)) ([1cbb681](1cbb681)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 ([#2732](#2732)) ([891b01d](891b01d)) * update dependency com.google.cloud:grpc-gcp to v1.6.0 ([#2767](#2767)) ([a39aa07](a39aa07)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2708](#2708)) ([4d7d246](4d7d246)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2709](#2709)) ([4e31d7d](4e31d7d)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.36.0 ([#2768](#2768)) ([22b7398](22b7398)) * update dependency commons-codec:commons-codec to v1.17.0 ([#2710](#2710)) ([b87356c](b87356c)) * update dependency jinja2 to v3.1.4 [security] ([#2742](#2742)) ([d67eaf8](d67eaf8)) * update dependency lxml to v5.2.2 ([#2766](#2766)) ([df7e211](df7e211)) * update dependency markupsafe to v2.1.5 ([#2657](#2657)) ([805baf8](805baf8)) * update dependency net.bytebuddy:byte-buddy to v1.14.15 ([#2753](#2753)) ([a472620](a472620)) * update dependency platformdirs to v4.2.1 ([#2662](#2662)) ([dbdcc91](dbdcc91)) * update googleapis/java-cloud-bom digest to db4265f ([#2755](#2755)) ([908db6f](908db6f)) * update googleapis/java-cloud-bom digest to f3c611a ([#2700](#2700)) ([d254e9b](d254e9b)) * update opentelemetry-java monorepo to v1.38.0 ([#2769](#2769)) ([0a5c7c4](0a5c7c4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing opentelemetry-bom in gapic-generator-java-bom (and thus Google Cloud Libraries BOM) wrongly implies that we (Google) publish the OpenTelemetry artifacts.
https://jlbp.dev/JLBP-15 states:
In this change, the opentelemetry-bom is declared in the third-party-dependencies BOM and thus will be excluded in the Google Cloud Libraries BOM, which does not import the third-party-dependencies BOM.
Related to b/338624813