Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create release cloudbuild yaml for library_generation #2510

Merged
merged 7 commits into from
Feb 28, 2024
Merged

chore: create release cloudbuild yaml for library_generation #2510

merged 7 commits into from
Feb 28, 2024

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Feb 27, 2024 •
edited
Loading

In this PR

  • We add a new cloudbuild yaml that is configured to push a new image tagged as gcr.io/cloud-devrel-public-resources/java-library-generation:${_GAPIC_GENERATOR_JAVA_VERSION}
  • We reorganize the folder structure of sdk-platform-java/.cloudbuild

The new trigger

It's called library-generation-sdk-platform-java-release
image

Before merging this PR

  • Update all library_generation triggers to point to the new location (.cloudbuild/library_generation)
  • Get approval from @mpeddada1 in order to:
    • Update graalvm test triggers to point to the new location (.cloudbuild/graalvm)
    • Update graalvm release triggers to point to the new location (.cloudbuild/graalvm)

@diegomarquezp diegomarquezp requested a review from a team as a code owner February 27, 2024 20:41
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 27, 2024
@diegomarquezp
Copy link
Contributor Author

@mpeddada1, What's the purpose of https://github.com/googleapis/sdk-platform-java/blob/main/.cloudbuild/google-cloud-sdk.repo ?
Should I keep it there or move it to .cloudbuild/graalvm?

mpeddada1
mpeddada1 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the question @diegomarquezp! I think the google-cloud-sdk.repo file can be removed. It was used in https://github.com/googleapis/java-shared-config/blob/a89db762fa5ff17856c4cde033996a2b8199123f/.cloudbuild/graalvm22_3_jdk11.Dockerfile#L30 to install gcloud on the docker image but is not used here since we're using the java-shared-config docker image as the base image. It ended up getting accidentally copied in here.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 28, 2024
@diegomarquezp diegomarquezp enabled auto-merge (squash) February 28, 2024 15:26
@diegomarquezp diegomarquezp added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@diegomarquezp diegomarquezp merged commit 7c09e23 into main Feb 28, 2024
40 checks passed
@diegomarquezp diegomarquezp deleted the library-generation-release-cloudbuild branch February 28, 2024 16:05
lqiu96 pushed a commit that referenced this pull request Feb 28, 2024
@diegomarquezp @lqiu96
chore: create release cloudbuild yaml for library_generation (#2510)
a68db84 
# In this PR
- We add a new `cloudbuild` yaml that is configured to push a new image
tagged as
`gcr.io/cloud-devrel-public-resources/java-library-generation:${_GAPIC_GENERATOR_JAVA_VERSION}`
 - We reorganize the folder structure of `sdk-platform-java/.cloudbuild`

## The new trigger
It's called `library-generation-sdk-platform-java-release`

![image](https://github.com/googleapis/sdk-platform-java/assets/22083784/b14525c5-fbe9-4d33-9381-4e6cbfae686a)


# Before merging this PR
- [x] Update _all_ library_generation triggers to point to the new
location (`.cloudbuild/library_generation`)
 - [x] Get approval from @mpeddada1 in order to:
- [x] Update graalvm __test__ triggers to point to the new location
(`.cloudbuild/graalvm`)
- [x] Update graalvm release triggers to point to the new location
(`.cloudbuild/graalvm`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

@mpeddada1 mpeddada1 mpeddada1 approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diegomarquezp @blakeli0 @mpeddada1 @JoeWang1127