Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration validation for renovate.json #1354

Closed
emmileaf opened this issue Feb 14, 2023 · 4 comments
Closed

Add configuration validation for renovate.json #1354

emmileaf opened this issue Feb 14, 2023 · 4 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@emmileaf
Copy link
Contributor

emmileaf commented Feb 14, 2023

Look into a way to add check to verify renovate.json in presubmit, so things like #1349's missed comma can be caught ahead of renovate bot issue.

@emmileaf emmileaf added type: process A process-related concern. May include testing, release, or the like. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 14, 2023
@emmileaf emmileaf self-assigned this Feb 14, 2023
@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 17, 2024
@blakeli0
Copy link
Collaborator

It happened again, we didn't notice the issue until a few months later, #2374

@emmileaf
Copy link
Contributor Author

Bleh this totally fell off my radar last year, sorry 🥲 Thank you @ddixit14 for figuring it out! 🙏

@emmileaf emmileaf removed their assignment Jan 26, 2024
@diegomarquezp diegomarquezp self-assigned this Feb 12, 2024
@diegomarquezp
Copy link
Contributor

diegomarquezp commented Feb 12, 2024

cc: @burkedavison @lqiu96
I'm planning to do a basic parsable JSON test and the use https://docs.renovatebot.com/config-validation/#config-validation

edit: maybe the parsable JSON check is included in this tool

@diegomarquezp
Copy link
Contributor

This was already fixed by #2404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants