fix: Persist missingValueInterpretationMap in StreamWriter's Builder #2587
+211
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
yifatgortler
requested review from
GaoleMeng and
yirutang
and removed request for
agrawal-siddharth
yifatgortler
changed the title
yirutang
reviewed
Aug 6, 2024
|
|
||
| /** @return the missing value interpretation map used for the writer. */ | ||
| public Map<String, AppendRowsRequest.MissingValueInterpretation> | ||
| getMissingValueInterpretationMap() { |
There was a problem hiding this comment.
Should we keep the get method?
| @@ -105,6 +105,7 @@ private SchemaAwareStreamWriter(Builder<T> builder) | |||
| streamWriterBuilder.setLocation(builder.location); | |||
| streamWriterBuilder.setDefaultMissingValueInterpretation( | |||
| builder.defaultMissingValueInterpretation); | |||
| streamWriterBuilder.setMissingValueInterpretationMap(builder.missingValueInterpretationMap); | |||
There was a problem hiding this comment.
Let's add a e2e test in the it directory?
yifatgortler
force-pushed
the
main
branch
4 times, most recently
from
9ce8a21
to
98963a1
Compare
|
Warning: This pull request is touching the following templated files:
|
…ase the StreamWriter is recreated, the map will be used in the new StreamWriter too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the StreamWriter is recreated, like during schema update, the map will be used in the new StreamWriter too.