Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 0.34.0 #1503

Merged
merged 2 commits into from
Apr 25, 2024
Merged

chore(main): release 0.34.0 #1503

merged 2 commits into from
Apr 25, 2024

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Apr 15, 2024

🤖 I have created a release beep boop

0.34.0 (2024-04-23)

Features

  • Add ability to echo request headers in trailing metadata (#1501) (48f9b74)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested review from a team as code owners April 15, 2024 20:41
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2024
@aandreassa
Copy link

@parthea anything blocking this release still? Otherwise, it could be useful for testing on our side. Thanks in advance!

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 22, 2024
@parthea
Copy link
Contributor

parthea commented Apr 22, 2024

@vchudnov-g will check if we want to release #1501 as is , or improve it to include HTTP Headers in the echo response as per offline discussion

@release-please release-please bot force-pushed the release-please--branches--main branch from a3c6711 to 291844b Compare April 23, 2024 16:13
@parthea
Copy link
Contributor

parthea commented Apr 25, 2024

@vchudnov-g Please could you take a look?

@vchudnov-g
Copy link
Contributor

I am about to put together a very short (internal) proposal to the effect that when we use transport="rest", we can echo the HTTP request headers in the HTTP response headers (with a prefix, etc.). So this would wind up being a distinct but analogous mechanism to what we're doing right now over gRPC.

@parthea and @noahdietz: if this idea sounds reasonable to you, then I am OK unblocking this release now. I expect to have the proposal out this week (today?), and the implementation just trivially later (I think it will be pretty simple).

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 25, 2024
@parthea parthea merged commit d3c515e into main Apr 25, 2024
11 checks passed
@parthea parthea deleted the release-please--branches--main branch April 25, 2024 20:02
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: tagged kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants