Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update auth version in showcase tests #2176

Merged

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Sep 20, 2024

This PR overrides the auth version to install google-auth with aiohttp option and also silences mypy warnings for type hint mismatch for credentials.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 20, 2024
@ohmayr ohmayr changed the base branch from main to async-rest-support-in-gapics September 20, 2024 05:04
@ohmayr ohmayr changed the title chore: update dependency versions noxfile chore: update auth and core versions for showcase tests Sep 20, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Sep 20, 2024
@ohmayr ohmayr force-pushed the update-dependency-versions-noxfile branch from f8a2c78 to 924d835 Compare September 20, 2024 05:23
@ohmayr ohmayr marked this pull request as ready for review September 20, 2024 05:23
@ohmayr ohmayr requested a review from a team as a code owner September 20, 2024 05:23
noxfile.py Outdated
Comment on lines 367 to 368
session.install('--no-cache-dir', '--force-reinstall', "google-api-core[grpc]==2.20.0")
session.install('--no-cache-dir', '--force-reinstall', "google-auth[aiohttp]==2.35.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these lines be removed now since the releases are on PyPI?

@ohmayr ohmayr force-pushed the update-dependency-versions-noxfile branch from 924d835 to d398a75 Compare September 20, 2024 16:25
@ohmayr ohmayr changed the title chore: update auth and core versions for showcase tests chore: update auth version in showcase tests Sep 20, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 20, 2024
@ohmayr ohmayr merged commit c2eab2d into async-rest-support-in-gapics Sep 20, 2024
73 checks passed
@ohmayr ohmayr deleted the update-dependency-versions-noxfile branch September 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants