feat: implement async rest interceptor class #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
force-pushed
the
implement-async-rest-interceptor-class
branch
2 times, most recently
from
4162fb1
to
e3860f4
Compare
ohmayr
force-pushed
the
implement-async-rest-interceptor-class
branch
5 times, most recently
from
29e11f6
to
a924358
Compare
ohmayr
force-pushed
the
refactor-interceptor-test
branch
from
3d07c26
to
a7045d7
Compare
ohmayr
force-pushed
the
implement-async-rest-interceptor-class
branch
from
a924358
to
26f41b4
Compare
ohmayr
force-pushed
the
refactor-interceptor-test
branch
from
a7045d7
to
4c5e881
Compare
ohmayr
force-pushed
the
implement-async-rest-interceptor-class
branch
2 times, most recently
from
1aa4ea8
to
b04a3f6
Compare
ohmayr
force-pushed
the
refactor-interceptor-test
branch
from
4c5e881
to
f1c87fc
Compare
ohmayr
force-pushed
the
implement-async-rest-interceptor-class
branch
2 times, most recently
from
74c9752
to
0d00ebc
Compare
parthea
approved these changes
Sep 23, 2024
Base automatically changed from
refactor-interceptor-test
to
async-rest-support-in-gapics
September 23, 2024 16:50
ohmayr
force-pushed
the
implement-async-rest-interceptor-class
branch
from
0d00ebc
to
5200771
Compare
ohmayr
commented
Sep 23, 2024
| @@ -2275,8 +2274,21 @@ def test_initialize_client_w_{{transport_name}}(): | |||
| @pytest.mark.parametrize("null_interceptor", [True, False]) | |||
| {{async_prefix}}def test_{{ method_name }}_{{transport_name}}_interceptors(null_interceptor): | |||
| {% if 'grpc' in transport %} | |||
| {# TODO(https://github.com/googleapis/gapic-generator-python/issues/2191): | |||
|
Note: This PR will be merged into the feature branch due to a pressing deadline. If there's any feedback, it will be addressed as a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the asynchronous rest interceptor class and leverages the rest / response async interceptor methods within the async
__call__method.This PR should be reviewed and merged after: #2150.