From 08ac1995b3e3d0398f44ec014221fdd6705976d6 Mon Sep 17 00:00:00 2001
From: Jon Skeet <jonskeet@google.com>
Date: Mon, 17 Jun 2024 12:13:41 +0100
Subject: [PATCH] feat: Remove reference assemblies and SourceLink for REST

This is the generator counterpart of https://github.com/googleapis/google-api-dotnet-client/pull/2776
---
 .../Google.Apis.Assuredworkloads.v1.csproj                      | 2 --
 .../Google.Apis.Calendar.v3/Google.Apis.Calendar.v3.csproj      | 2 --
 .../Google.Apis.CloudRun.v1/Google.Apis.CloudRun.v1.csproj      | 2 --
 .../Google.Apis.CloudSupport.v2.csproj                          | 2 --
 .../Google.Apis.DataprocMetastore.v1.csproj                     | 2 --
 .../Google.Apis.ManufacturerCenter.v1.csproj                    | 2 --
 .../Google.Apis.Storage.v1/Google.Apis.Storage.v1.csproj        | 2 --
 .../Google.Apis.Translate.v2/Google.Apis.Translate.v2.csproj    | 2 --
 .../Google.Apis.Webfonts.v1/Google.Apis.Webfonts.v1.csproj      | 2 --
 Google.Api.Generator.Rest/Models/PackageModel.cs                | 2 --
 10 files changed, 20 deletions(-)

diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Assuredworkloads.v1/Google.Apis.Assuredworkloads.v1.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Assuredworkloads.v1/Google.Apis.Assuredworkloads.v1.csproj
index 3f811581..b8191d9a 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Assuredworkloads.v1/Google.Apis.Assuredworkloads.v1.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Assuredworkloads.v1/Google.Apis.Assuredworkloads.v1.csproj
@@ -55,9 +55,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Calendar.v3/Google.Apis.Calendar.v3.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Calendar.v3/Google.Apis.Calendar.v3.csproj
index 3a45cba4..4a27ad74 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Calendar.v3/Google.Apis.Calendar.v3.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Calendar.v3/Google.Apis.Calendar.v3.csproj
@@ -58,9 +58,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudRun.v1/Google.Apis.CloudRun.v1.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudRun.v1/Google.Apis.CloudRun.v1.csproj
index 38a5ef0a..7cf0fc63 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudRun.v1/Google.Apis.CloudRun.v1.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudRun.v1/Google.Apis.CloudRun.v1.csproj
@@ -58,9 +58,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudSupport.v2/Google.Apis.CloudSupport.v2.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudSupport.v2/Google.Apis.CloudSupport.v2.csproj
index 29623cbb..80584f2f 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudSupport.v2/Google.Apis.CloudSupport.v2.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.CloudSupport.v2/Google.Apis.CloudSupport.v2.csproj
@@ -55,9 +55,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.DataprocMetastore.v1/Google.Apis.DataprocMetastore.v1.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.DataprocMetastore.v1/Google.Apis.DataprocMetastore.v1.csproj
index fe57ba94..7f3965b4 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.DataprocMetastore.v1/Google.Apis.DataprocMetastore.v1.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.DataprocMetastore.v1/Google.Apis.DataprocMetastore.v1.csproj
@@ -58,9 +58,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.ManufacturerCenter.v1/Google.Apis.ManufacturerCenter.v1.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.ManufacturerCenter.v1/Google.Apis.ManufacturerCenter.v1.csproj
index bed2ccc9..c8fc4314 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.ManufacturerCenter.v1/Google.Apis.ManufacturerCenter.v1.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.ManufacturerCenter.v1/Google.Apis.ManufacturerCenter.v1.csproj
@@ -58,9 +58,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Storage.v1/Google.Apis.Storage.v1.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Storage.v1/Google.Apis.Storage.v1.csproj
index 96dcdddf..b7e6400e 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Storage.v1/Google.Apis.Storage.v1.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Storage.v1/Google.Apis.Storage.v1.csproj
@@ -59,9 +59,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/Google.Apis.Translate.v2.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/Google.Apis.Translate.v2.csproj
index 1ba41834..0c95afba 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/Google.Apis.Translate.v2.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/Google.Apis.Translate.v2.csproj
@@ -59,9 +59,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
     <PackageReference Include="Google.Apis.Auth" Version="1.54.0" />
   </ItemGroup>
diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Webfonts.v1/Google.Apis.Webfonts.v1.csproj b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Webfonts.v1/Google.Apis.Webfonts.v1.csproj
index a5c93e91..557b73b7 100644
--- a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Webfonts.v1/Google.Apis.Webfonts.v1.csproj
+++ b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Webfonts.v1/Google.Apis.Webfonts.v1.csproj
@@ -58,9 +58,7 @@
 
   <!-- common dependencies -->
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0" PrivateAssets="All" />
-    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
     <PackageReference Include="Google.Apis" Version="1.54.0" />
   </ItemGroup>
 
diff --git a/Google.Api.Generator.Rest/Models/PackageModel.cs b/Google.Api.Generator.Rest/Models/PackageModel.cs
index f0f380e2..17bfc111 100644
--- a/Google.Api.Generator.Rest/Models/PackageModel.cs
+++ b/Google.Api.Generator.Rest/Models/PackageModel.cs
@@ -362,9 +362,7 @@ public XDocument GenerateProjectFile(IClock clock)
             );
 
             var commonDependencies = new XElement("ItemGroup",
-                PackageReference("Microsoft.NETFramework.ReferenceAssemblies", "1.0.2", new XAttribute("PrivateAssets", "All")),
                 PackageReference("ConfigureAwaitChecker.Analyzer", "5.0.0", new XAttribute("PrivateAssets", "All")),
-                PackageReference("SourceLink.Create.CommandLine", "2.8.3", new XAttribute("PrivateAssets", "All")),
                 PackageReference("Google.Apis", _features.CurrentSupportVersion),
                 AuthScopes.Any() ? PackageReference("Google.Apis.Auth", _features.CurrentSupportVersion) : null
             );