Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark informative audit N/A when no tag loads. #261

Open
jburger424 opened this issue Feb 23, 2021 · 0 comments
Open

Mark informative audit N/A when no tag loads. #261

jburger424 opened this issue Feb 23, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jburger424
Copy link
Contributor

With the implementation of the new audits "Deprecated GPT API Usage" and "GPT Errors", pages without GPT (e.g. example.com) will score a 0 for Publisher Ads.

Before, the category score would be set to N/A on these sites, but because these are not set as N/A, the category score is being set according to the 2 applicable audits.

I'll file a bug in LH to discuss this, as it seems like the wrong default behavior for informative audits, but in the meantime it'd be good to fix the issue on our end.

+CC: @warrengm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants