Fix #449: Avoid exception in ValidateTransferWalkingTime if lat/lon is unset

tests/transitfeed/testtransfer.py

@@ -298,6 +298,21 @@ def testVeryCloseStationsDoNotTriggerWarning(self):
     transfer.Validate(self.problems)
     self.accumulator.AssertNoMoreExceptions()
 
+  def testStationsWithoutCoordsDoNotCrashValidation(self):
+    # from_stop_id and to_stop_id are present in schedule,
+    # but one of the stops has no coordinates
+    schedule = transitfeed.Schedule()
+    stop1 = schedule.AddStop(57.5, 30.2, "stop 1")
+    stop2 = schedule.AddStop(None, None, "stop 2")
+    transfer = transitfeed.Transfer(schedule=schedule)
+    transfer.from_stop_id = stop1.stop_id
+    transfer.to_stop_id = stop2.stop_id
+    transfer.transfer_type = 2
+    transfer.min_transfer_time = 60
+    repr(transfer)  # shouldn't crash
+    transfer.Validate(self.problems)
+    self.accumulator.AssertNoMoreExceptions()
+
   def testCustomAttribute(self):
     """Add unknown attributes to a Transfer and make sure they are saved."""
     transfer = transitfeed.Transfer()

transitfeed/transfer.py

@@ -154,6 +154,10 @@ def ValidateTransferWalkingTime(self, problems):
       return
 
     distance = self.GetTransferDistance()
+    # if distance is None, lat/lon of one or both stops are invalid,
+    # which is already reported
+    if distance is None:
+      return
     # If min_transfer_time + 120s isn't enough for someone walking very fast
     # (2m/s) then issue a warning.
     #