This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Fix schedule viewer ui #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text element just under the schedule's SVG was partially hidden when the bottombar's height was set to 175px. I tried to remove the height property or to set it to auto. This was working great under Chrome, but Firefox seems to have problem calculating the content element's height... unless the debug pane was opened (???) So, for now, fix the height by setting a proper value (198px). Fix a comment at the same time for readability. Signed-off-by: Alexandre Demers <[email protected]>
The yyyy, MM and dd values were added one to the other under setStartDate(). 2018, 11, 21 would end up being 2050 instead of 20181121. Force the variables to be treated as strings. Signed-off-by: Alexandre Demers <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simple fixes: