Use absl's locale-independent conversion functions in XPRESS MPSolver interface #4382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using such functions as
std::stoi
,std::stod
, etc. caused us a lot of trouble because these functions are locale dependent, as illustrated belowAt first, we thought that using
ScopedLocale
would allow us to temporarily use the "C" locale, but this approach has multiple problemsstd::stod
when the locale is being changed throughstd::setlocale
is undefined behavior source.const char*
pointers easily become dangling or invalid without the caller knowingWe ran into an issue where the locale wasn't properly restored after using
MPSolver::XpressInterface
. So we decided to use absl's locale independent functions to perform that task.