From 9b4c306ff4275c0569c887e4cbfeb7b2dcd31a5e Mon Sep 17 00:00:00 2001 From: Sean Martin Date: Fri, 27 Sep 2024 11:58:38 +0200 Subject: [PATCH] fix: handle correclty the pixel indicator on zoom in UI --- src/ui/screenshot_menu.ts | 1 + src/util/screenshot_manager.ts | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/ui/screenshot_menu.ts b/src/ui/screenshot_menu.ts index 5c8bd8429..b27bb7fcf 100644 --- a/src/ui/screenshot_menu.ts +++ b/src/ui/screenshot_menu.ts @@ -131,6 +131,7 @@ export class ScreenshotDialog extends Overlay { throttle(() => { this.populateLayerResolutionTable(); this.handleScreenshotResize(); + this.populatePanelResolutionTable(); }, 500), ); constructor(private screenshotManager: ScreenshotManager) { diff --git a/src/util/screenshot_manager.ts b/src/util/screenshot_manager.ts index 8c6da8d25..abcbda08e 100644 --- a/src/util/screenshot_manager.ts +++ b/src/util/screenshot_manager.ts @@ -119,8 +119,8 @@ export class ScreenshotManager extends RefCounted { screenshotStartTime = 0; screenshotMode: ScreenshotMode = ScreenshotMode.OFF; statisticsUpdated = new Signal<(state: ScreenshotLoadStatistics) => void>(); - zoomMaybeChanged = new NullarySignal(); screenshotFinished = new NullarySignal(); + zoomMaybeChanged = new NullarySignal(); private _shouldKeepSliceViewFOVFixed: boolean = true; private _screenshotScale: number = 1; private filename: string = ""; @@ -208,6 +208,7 @@ export class ScreenshotManager extends RefCounted { public set screenshotScale(scale: number) { this.handleScreenshotZoom(scale); this._screenshotScale = scale; + this.zoomMaybeChanged.dispatch(); } public get shouldKeepSliceViewFOVFixed() { @@ -219,8 +220,10 @@ export class ScreenshotManager extends RefCounted { this._shouldKeepSliceViewFOVFixed = enableFixedFOV; if (!enableFixedFOV && wasInFixedFOVMode) { this.handleScreenshotZoom(1 / this.screenshotScale, true /* resetZoom */); + this.zoomMaybeChanged.dispatch(); } else if (enableFixedFOV && !wasInFixedFOVMode) { this.handleScreenshotZoom(this.screenshotScale, true /* resetZoom */); + this.zoomMaybeChanged.dispatch(); } } @@ -322,7 +325,6 @@ export class ScreenshotManager extends RefCounted { break; } } - this.zoomMaybeChanged.dispatch(); } }