Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mug-bigquery artifact to apply StringFormat templating for BigQuery #53

Merged
merged 7 commits into from
Dec 3, 2023

Conversation

xingyutangyuan
Copy link
Contributor

No description provided.

@fluentfuture
Copy link
Collaborator

Thanks for the PR!

Some thoughts on naming.

BigQuery's QueryJobConfiguration is usually referred to as "parameterized query" so I feel like we can try to get behind that name. It's also more specific than "Safe".

Also, if we name the class ParameterizedQuery, maybe it can be consolidated with TrustedSql. A "ParameterizedQuery" itself is trusted, right?

@xingyutangyuan
Copy link
Contributor Author

Renamed to ParameterizedQuery.

@fluentfuture fluentfuture merged commit 02b42b7 into google:master Dec 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants