Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scene switch lags opacity transition animation #299

Closed
un0btanium opened this issue Apr 3, 2020 · 6 comments
Closed

scene switch lags opacity transition animation #299

un0btanium opened this issue Apr 3, 2020 · 6 comments
Labels

Comments

@un0btanium
Copy link

un0btanium commented Apr 3, 2020

I noticed that when I have pinFirstLevel: false that the panorama image I switch to is loaded while the transition occurs. The loading process of the image is causing the webpage to freeze, interrupting the transition. Once the image is loaded the transition is trying to catch up, making the transition seem almost complete instantly and looking very unsmooth and buggy.

The same problem exists when I add a low resolution preview and a high resolution level (and put pinFirstLevel to true). Then the preview images are loaded on startup and the high resolution image is loaded lagging the transition to the scene.

I am currently using equirectangular panorama image. Would this be the cause because the images are large ones and need to be loaded in its entirety? I feel like this issue is related to this one. Would using cube maps instead fix the issue for good?

@tjgq
Copy link
Collaborator

tjgq commented Apr 24, 2020

Maybe. Large equirectangular images result in a suboptimal rendering experience because they can't be loaded in small pieces. I would generally recommend using cubemaps.

There is also an open PR to do the image loading off-thread, which might help here.

@tjgq tjgq added the question label Apr 24, 2020
@un0btanium
Copy link
Author

Is there a tool you would recommend for splitting a equirectangular image into cubemaps (idealy one that already generates different, customizable tile grid sizes and levels of details and outputs them in seperate folders)?

Interesting that we are getting threading in the browser. Cant wait till that is officially merged and working for more browsers.

@campmdabt
Copy link

campmdabt commented Apr 24, 2020 via email

@tjgq
Copy link
Collaborator

tjgq commented Apr 24, 2020

The krpano tools definitely work; Hugin is a free (open source) alternative.

@un0btanium
Copy link
Author

Someone knows how the Marzipano Editor Tool does it?

@campmdabt
Copy link

Looks like it pulls down https://www.marzipano.net/tool/js/equirect.worker.js to do the work, but neither the ../LICENSES.txt file it references nor the code itself betrays what it's using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants