Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Rust crates #718

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Release Rust crates #718

merged 1 commit into from
Sep 26, 2024

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Sep 25, 2024

No description provided.

@ia0 ia0 marked this pull request as draft September 25, 2024 13:01
@ia0
Copy link
Member Author

ia0 commented Sep 25, 2024

Need to fix MacOS.

@ia0
Copy link
Member Author

ia0 commented Sep 25, 2024

MacOS "fix" coming in #719. Not sure what's the default in ONNX, but seems like we need to set some value.

@reyammer
Copy link
Collaborator

Note that the checks didn't pick up yet the new gh actions workflow that actually builds & test the package. Can we re-trigger all the workflows?

@ia0
Copy link
Member Author

ia0 commented Sep 25, 2024

Note that the checks didn't pick up yet the new gh actions workflow that actually builds & test the package. Can we re-trigger all the workflows?

The new workflow doesn't trigger when only rust files are touched, so it's working as intended. Why do you want the workflow to run? Maybe removing the paths restriction would be better?

@reyammer
Copy link
Collaborator

good catch; I thought it was just stale. I just updated the e2e test workflow to trigger also for rust/** modifications. Now it's running the checks again, and the build package is triggered, seems to work.

@ia0
Copy link
Member Author

ia0 commented Sep 26, 2024

good catch; I thought it was just stale. I just updated the e2e test workflow to trigger also for rust/** modifications. Now it's running the checks again, and the build package is triggered, seems to work.

Sounds good. I'll fix the problem in a different PR (to keep this PR small). It's a bug in the recent nightly rust-lang/rust-clippy#13458

@ia0 ia0 merged commit e5a8768 into google:main Sep 26, 2024
25 checks passed
@ia0 ia0 deleted the publish branch September 26, 2024 11:41
@ia0
Copy link
Member Author

ia0 commented Sep 26, 2024

This is tagged as rust-v0.1.0-rc.1 and published as magika and magika-cli. Because it's a pre-release, the version must be explicitly specified:

Crate Command to use or install
Library cargo add magika@=0.1.0-rc.1
CLI cargo install --locked [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants