New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all opened input streams are closed #2143

Merged

ting-yuan merged 1 commit into google:main from ansman:fix/close-streams

Oct 10, 2024

Contributor

ansman commented Oct 10, 2024

No description provided.


          Ensure all opened input streams are closed

ea099aa

ZacSweers approved these changes

View reviewed changes

ansman commented

View reviewed changes

compiler-plugin/src/main/kotlin/com/google/devtools/ksp/common/PersistentMap.kt

@@ @@ -53,7 +54,7 @@ abstract class PersistentMap<K, V>( @@
                       @OptIn(ExperimentalSerializationApi::class)
                       protected fun <K, V> deserialize(serializer: KSerializer<Map<K, V>>, storage: File): MutableMap<K, V> {
                           return if (storage.exists()) {
-                              storage.inputStream().use {
+                              BufferedInputStream(storage.inputStream()).use {

Contributor Author

ansman Oct 10, 2024

From what I can tell, Json.decodeFromStream doesn't buffer internally

ting-yuan approved these changes

View reviewed changes

ting-yuan merged commit 5b6d886 into google:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet