Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux test vectors: assign key length, message size, tweak size randomly #9

Open
ciphergoth opened this issue Nov 1, 2021 · 0 comments

Comments

@ciphergoth
Copy link
Collaborator

@ebiggers writes:

This PR makes it so that there are two test vectors per message size per key size, so 6 total per message size. Maybe cut that down to 1 per message size per key size, so 3 total per message size? Or even less and just assign key sizes randomly.

not very effective to have 2 test vectors per message length per key length. Problems are more likely to arise for different length inputs, not for different input contents. The xctr test vectors are especially odd, as they only test 32 and 255-byte messages, but have 6 test vectors for each length. We could get better test coverage in the same number (or fewer) of test vectors by focusing on different lengths rather than different contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant