Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of parameters in @-files: add quote-handling for whitespaces in parameters. #931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve handling of parameters in @-files: add quote-handling for whitespaces in parameters. #931

wants to merge 3 commits into from

Commits on Apr 7, 2023

  1. CommandLineOptions: disallow recursive embedding of @-files. 

    And tests.
    @kfriedberger
    kfriedberger committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1b2931a View commit details
    Browse the repository at this point in the history

  2. CommandLineOptions: allow quotes in @-files, e.g., for parameters con… 

    …taining whitespace.

Parameters from @-files are no longer simply split at whitespace,
but now recognize quotes (single or double quotes allowed),
such that parameters can contain whitespace that are kept unmodified.

Each parameter can be written as either a quoted string (single or double quotes are allowed) or a plain unquoted string.
Surrounding quotes are removed from parameters when parsing.
It is possible to have double quotes within a single-quoted string and vice-versa.
Such internal quotes remain untouched when parsing.
For simplicity, we do not handle escaped quotes.
    @kfriedberger
    kfriedberger committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c6fab2f View commit details
    Browse the repository at this point in the history

  3. CommandLineOptions: allow open-ended quotes in @-files. 

    We do not enforce an ending quote in @-files
and simply close the string on end-fo-file.
This might be nicer for the user and does not harm.
    @kfriedberger
    kfriedberger committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ad09e3d View commit details
    Browse the repository at this point in the history