-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note on executable google-java-format #414
base: master
Are you sure you want to change the base?
Conversation
google-java-format
.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
67dcbdb
to
18c8e48
Compare
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I think this was addressed in #44. |
The issue 44 was addressed by adding flag to specify the location of the executable. Still this repository is missing how to create the executable. |
there's also fa113c6 |
That command line option lets users specify a custom JAR file, without using an executable. This does not describe how to create the executable. |
aren't the two approaches equivalent? |
Yes the effect of two approaches (the custom JAR approach and the executable-in-PATH approach) is the same. This equivalence should not block enhancing the document for one approach. By the way, I like the executable-in-PATH approach because the command line parameter is shorter for google-java-format-diff.py. |
@eaftan Thank you for checking. Would you merge this PR? I don’t have write access. |
@suztomo I'm testing a new sync workflow. By approving this PR, I had hoped it would be automatically pulled into an internal CL, which we could then approve and submit internally. Then that change would be synced outward and this PR closed. But approving this didn't create the internal CL. Let me poke it and see if I can make it work. |
Google-java-format-diff expects an executable
google-java-format
(link), but this repository does not contain such file. This PR explains how to create such executable in README.md.