Fixes detection if the image contains compressed layers #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This Pull Request is stale because it has been open for 90 days with |
|
@jonjohnsonjr Can you please take a look at this patch and see if it can be taken in?, facing the same issue while using crane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the detection for an image with compressed layers.
Currently only the first base layer is probed to determine whether the image contains compressed layers.
However, the image may consist from a uncompressed base layer and compressed upper layers.
Typically for the image windows-host-process-container-base-image shipped from MSFT,
the base layer is a tar without compression.
Images built using BuildKit upon windows-host-process-container-base-image will become a mixed form
of uncompressed base layer and compressed upper layers.
It will result in a broken image with wrong blob after they are pushed to the registry.
Fixes: #1980