Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation error of the weights compression tool #422

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix compilation error of the weights compression tool #422

merged 1 commit into from
Oct 14, 2024

Conversation

ufownl
Copy link
Contributor

@ufownl ufownl commented Oct 11, 2024 •
edited
Loading

GCC (Linux) returns the errors about the missing "typename", and Clang (macOS) also returns the warnings about them.

jan-wassenberg
jan-wassenberg approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) C++20 has relaxed this typename requirement such that it wouldn't be required, but we can certainly add it back.

@jan-wassenberg jan-wassenberg added the copybara-import Trigger Copybara for merging pull requests label Oct 14, 2024
@copybara-service copybara-service bot merged commit 2892e23 into google:dev Oct 14, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-wassenberg jan-wassenberg jan-wassenberg approved these changes

Assignees
No one assigned
Labels
copybara-import Trigger Copybara for merging pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ufownl @jan-wassenberg