Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Remove oauth2client #97

Open
whilp opened this issue Aug 19, 2018 · 0 comments
Open

Remove oauth2client #97

whilp opened this issue Aug 19, 2018 · 0 comments

Comments

@whilp
Copy link

whilp commented Aug 19, 2018

This library is deprecated:

https://google-auth.readthedocs.io/en/latest/oauth2client-deprecation.html

Its presence complicates use of containerregistry in Python3. Fortunately, this is the only import:

from oauth2client import client as oauth2client

And I can't even find a use of that import in docker_creds_. The only other reference in that file is a comment:

# WORKAROUND...
# The python oauth2client library only loads the credential from an
# on-disk cache the first time 'refresh()' is called, and doesn't
# actually 'Force a refresh of access_token' as advertised.
# This call will load the credential, and the call below will refresh
# it as needed. If the credential is unexpired, the call below will
# simply return a cache of this refresh.

Given that oauth2client doesn't seem to actually be used for anything and that removal would reduce the list of deps, simplify Python3 support, shall we?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant