Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to known-good version of googletest #23

Open
garrettkajmowicz-sophos opened this issue Jul 19, 2022 · 1 comment
Open

Pin to known-good version of googletest #23

garrettkajmowicz-sophos opened this issue Jul 19, 2022 · 1 comment

Comments

@garrettkajmowicz-sophos
Copy link

Can we have the build script fetch a known-good version of the googletest repository rather then head-of line?
This will stop people from running into issues like this one:

google/googletest#3934

when building the code here.
TedLyngmo added a commit to TedLyngmo/compact_enc_det that referenced this issue Dec 31, 2022
@TedLyngmo
Fetch a known-good version of googletest
6e82eac 
Compilation currently fails when using the latest googletest.
This patch instead downloads release-1.12.1 (which is the latest
release right now).

Fixes issue google#23.

Also added a .gitignore file.

Signed-off-by: Ted Lyngmo <[email protected]>
@TedLyngmo TedLyngmo mentioned this issue Dec 31, 2022
Merged
@TedLyngmo
Copy link
Contributor

@garrettkajmowicz-sophos Can you verify that it's working after the merge of #24?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TedLyngmo @garrettkajmowicz-sophos