Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--benchmark_min_time command line option undocumented #1878

Open
kpet opened this issue Nov 13, 2024 · 1 comment
Open

--benchmark_min_time command line option undocumented #1878

kpet opened this issue Nov 13, 2024 · 1 comment
Labels
docs documentation update needed good first issue help wanted

Comments

@kpet
Copy link

kpet commented Nov 13, 2024

The documentation mentions it once but I couldn't find comprehensive documentation for it. As far as I can tell, this option can be used for two things

  1. Set the min duration of a repetition with --benchmark_min_time=<value> or --benchmark_min_time=<value>s.
  2. Set the desired number of iterations per repetition with --benchmark_min_time=<value>x (for benchmarks not registered with a fixed number of iterations).

This seems like it relates to #746

Are both of these bits of behaviour officially supported? If yes, it would be helpful to document them.

@dmah42
Copy link
Member

dmah42 commented Nov 15, 2024

if they're in the code, they're supported. if we're missing some documentation, i'm happy to take PRs improving the docs.

@dmah42 dmah42 added help wanted docs documentation update needed good first issue labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation update needed good first issue help wanted
Projects
None yet
Development

No branches or pull requests

2 participants