From fd6c6fa57f73fcbf3472b66a648648a710f1f050 Mon Sep 17 00:00:00 2001 From: emcmanus Date: Mon, 25 Jun 2018 08:20:19 -0700 Subject: [PATCH] Adjust AutoValueTest so that it covers setting an immutable collection of T from a Collection. The actual bug was fixed long ago but never closed and never covered by an explicit test. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201956399 --- .../test/java/com/google/auto/value/AutoValueTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/value/src/it/functional/src/test/java/com/google/auto/value/AutoValueTest.java b/value/src/it/functional/src/test/java/com/google/auto/value/AutoValueTest.java index fbd378a6e2..b2ed4bed7b 100644 --- a/value/src/it/functional/src/test/java/com/google/auto/value/AutoValueTest.java +++ b/value/src/it/functional/src/test/java/com/google/auto/value/AutoValueTest.java @@ -2189,13 +2189,13 @@ public void testBuilderWithExoticPropertyBuilders() { public abstract static class BuilderWithCopyingSetters { public abstract ImmutableSet things(); - public abstract ImmutableList strings(); + public abstract ImmutableList numbers(); public abstract ImmutableMap map(); public static Builder builder(T value) { return new AutoValue_AutoValueTest_BuilderWithCopyingSetters.Builder() - .setStrings(ImmutableSet.of("foo", "bar")) + .setNumbers(ImmutableSet.of(17, 23.0)) .setMap(Collections.singletonMap("foo", value)); } @@ -2207,7 +2207,7 @@ public interface Builder { Builder setThings(T... things); - Builder setStrings(Collection strings); + Builder setNumbers(Collection strings); Builder setMap(Map map); @@ -2221,7 +2221,7 @@ public void testBuilderWithCopyingSetters() { BuilderWithCopyingSetters a = builder.setThings(ImmutableSet.of(1, 2)).build(); assertEquals(ImmutableSet.of(1, 2), a.things()); - assertEquals(ImmutableList.of("foo", "bar"), a.strings()); + assertEquals(ImmutableList.of(17, 23.0), a.numbers()); assertEquals(ImmutableMap.of("foo", 23), a.map()); BuilderWithCopyingSetters b = builder.setThings(Arrays.asList(1, 2)).build();