Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check bundle optional for localized string #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nrurnru
Copy link

@nrurnru nrurnru commented Feb 29, 2024

resolve #309

Add optional check for bundle of framework.
In this case UIAlertAction occurred crash because localizedStringForKey returned nil.

Swift version already has check this way.

guard let frameworkBundle = Bundle.gidFrameworkBundle() else { return text }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSInternalInconsistencyException GIDEMMErrorHandler
1 participant