Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve doc comment for GIDSignInButtonStyle #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve doc comment for GIDSignInButtonStyle #204

wants to merge 1 commit into from

Conversation

kamimi01
Copy link

I worked on #203

I think to be customizable the display text is better than adding document comments like this, so this is a workaround.

@petea petea linked an issue Aug 22, 2022 that may be closed by this pull request
Fix document comment of GoogleSignIn (product "GoogleSignIn") #203
Open
@petea petea changed the title fix: Document comment for GIDSignInButtonStyle Improve doc comment for GIDSignInButtonStyle Aug 22, 2022
@kamimi01
Copy link
Author

@petea Hi team,
Thank you for checking my pull request. As I mentioned, I think to be customizable display text is better than adding doc comments. Do you have a plan to be able to customize it? If you don't, would you mind telling me a reason?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix document comment of GoogleSignIn (product "GoogleSignIn")
1 participant
@kamimi01