Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document comment of GoogleSignIn (product "GoogleSignIn") #203

Open
kamimi01 opened this issue Aug 21, 2022 · 0 comments · May be fixed by #204
Open

Fix document comment of GoogleSignIn (product "GoogleSignIn") #203

kamimi01 opened this issue Aug 21, 2022 · 0 comments · May be fixed by #204

Comments

@kamimi01
Copy link

kamimi01 commented Aug 21, 2022 •
edited
Loading

Description

I've realized that there is a difference between the display text of ".standard" and ".wide" when we use "GIDSignInButtonStyle" property.
But there is no document comments in GIDSignInButton.h about it.
I think that should be written in the source code or the display text should be able to customize

  • standard: "Sign in"
  • wide: "Sign in with Google"
standard wide
@kamimi01 kamimi01 linked a pull request Aug 21, 2022 that will close this issue
Open
@petea petea linked a pull request Aug 22, 2022 that will close this issue
Improve doc comment for GIDSignInButtonStyle #204
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve doc comment for GIDSignInButtonStyle kamimi01/GoogleSignIn-iOS
1 participant
@kamimi01