Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate a custom tip: Android Basics with Compose #215

Open
dscottd7 opened this issue Jul 7, 2024 · 0 comments
Open

Calculate a custom tip: Android Basics with Compose #215

dscottd7 opened this issue Jul 7, 2024 · 0 comments

Comments

@dscottd7
Copy link

dscottd7 commented Jul 7, 2024

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-calculate-tip?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-calculate-tip#3

In which task and step of the codelab can this issue be found?
Add a tip-percentage text field

Describe the problem
In item 7, there is a code snippet that has onValueChanged = { } which I think should be onValueChange = { }. Just a typo.

EditNumberField(
    label = R.string.how_was_the_service,
    value = "",
    onValueChanged = { },
    modifier = Modifier.padding(bottom = 32.dp).fillMaxWidth()
)

Steps to reproduce?

  1. Go to item 7 on page https://developer.android.com/codelabs/basic-android-kotlin-compose-calculate-tip?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-calculate-tip#3
  2. See code snippet that has onValueChanged = { }

Versions
Android Studio version: 17.0.10
API version of the emulator: UpsideDownCake

Additional information
Include screenshots if they would be useful in clarifying the problem.
Screenshot 2024-07-07 at 1 07 29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant