Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom navigation always appears #118

Open
angelomarzocchi opened this issue Sep 29, 2024 · 0 comments
Open

Bottom navigation always appears #118

angelomarzocchi opened this issue Sep 29, 2024 · 0 comments

Comments

@angelomarzocchi
Copy link

``The bottom navigation always appears. As a matter of fact, I don't see why it should not render since there is no condition for it.
The only way I could find to go on with the Course unit was the following :
@composable
private fun ReplyAppContent(
navigationType: ReplyNavigationType,
replyUiState: ReplyUiState,
onTabPressed: ((MailboxType) -> Unit),
onEmailCardPressed: (Email) -> Unit,
navigationItemContentList: List,
modifier: Modifier = Modifier,
) {
Box(modifier = modifier) {
val navigationRailContentDescription = stringResource(R.string.navigation_rail)
ReplyNavigationRail(
currentTab = replyUiState.currentMailbox,
onTabPressed = onTabPressed,
navigationItemContentList = navigationItemContentList,
modifier = Modifier
.testTag(navigationRailContentDescription)
)
Column(
modifier = Modifier
.fillMaxSize()
.background(MaterialTheme.colorScheme.inverseOnSurface)
) {
ReplyListOnlyContent(
replyUiState = replyUiState,
onEmailCardPressed = onEmailCardPressed,
modifier = Modifier
.weight(1f)
.padding(
horizontal = dimensionResource(R.dimen.email_list_only_horizontal_padding)
)
)
val bottomNavigationContentDescription = stringResource(R.string.navigation_bottom)
// HERE !
if(navigationType == ReplyNavigationType.BOTTOM_NAVIGATION)
ReplyBottomNavigationBar(
currentTab = replyUiState.currentMailbox,
onTabPressed = onTabPressed,
navigationItemContentList = navigationItemContentList,
modifier = Modifier
.fillMaxWidth()
)
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant