Quasilinear model refactoring #497
Open
+331
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_694086811
branch
from
c2adec5
to
fa11996
Compare
This was referenced Nov 7, 2024
copybara-service
bot
force-pushed
the
test_694086811
branch
4 times, most recently
from
26c1772
to
d276cd2
Compare
1. Abstract away calculations (normalized logarithmic gradients, alpha_MHD, chi_GB) used for QuaLiKiz models, and define them in the quasilinear_transport_model module, such that they can be reused for other quasilinear models like TGLF, TGLF-NN. 2. In qualikiz_based_transport_model, directly use values from core_profiles including cell_variable methods where needed, instead of pre-defining potentially confusing helper variables. PiperOrigin-RevId: 694086811
copybara-service
bot
force-pushed
the
test_694086811
branch
from
d276cd2
to
e4a7ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quasilinear model refactoring
Abstract away calculations (normalized logarithmic gradients, alpha_MHD, chi_GB) used for QuaLiKiz models, and define them in the quasilinear_transport_model module, such that they can be reused for other quasilinear models like TGLF, TGLF-NN.
In qualikiz_based_transport_model, directly use values from core_profiles including cell_variable methods where needed, instead of pre-defining potentially confusing helper variables.