Move general configuration from Coordinator to DeviceSettings.
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_687495197
branch
3 times, most recently
from
0e8294b
to
8cc88a2
Compare
This change moves some device configuration settings out of `Coordinator` to a
new class `DeviceSettings`, which for now contains logic for setting visual
debug ("show touch" and "show pointer location"), status/navigation bars, and
the device orientation. The class is also thoroughly tested.
PiperOrigin-RevId: 688949117
copybara-service
bot
force-pushed
the
test_687495197
branch
from
8cc88a2
to
6e73777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move general configuration from
CoordinatortoDeviceSettings.This change moves some device configuration settings out of
Coordinatorto anew class
DeviceSettings, which for now contains logic for setting visualdebug ("show touch" and "show pointer location"), status/navigation bars, and
the device orientation. The class is also thoroughly tested.