Remove adb_server_port from EmulatorLauncher.
#162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
The emulator doesn't query the `ANDROID_ADB_SERVER_PORT` environment variable, so it shouldn't be set. We can then remove one confusing argument from `__init__()` since there's already an `adb_port`. PiperOrigin-RevId: 561095163
copybara-service
bot
force-pushed
the
test_561095163
branch
from
2c581cf
to
c70fc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
adb_server_portfromEmulatorLauncher.The emulator doesn't query the
ANDROID_ADB_SERVER_PORTenvironment variable,so it shouldn't be set. We can then remove one confusing argument from
__init__()since there's already anadb_port.