Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Code not matching tutorial #30

Open
LostEchoDX opened this issue Jul 29, 2021 · 1 comment
Open

Code not matching tutorial #30

LostEchoDX opened this issue Jul 29, 2021 · 1 comment
Assignees

Comments

@LostEchoDX
Copy link

LostEchoDX commented Jul 29, 2021

Hello, I've done extensive testing and found the following: on step 4, part 4 of Add a reticle the following code is on the tutorial:

async onSessionStarted() {
  // ...

  // Setup an XRReferenceSpace using the "local" coordinate system.
  this.localReferenceSpace = await **_session_**.requestReferenceSpace("local");

  // Add these lines:
  // Create another XRReferenceSpace that has the viewer as the origin.
  this.viewerSpace = await this.**_session_**.requestReferenceSpace("viewer");
  // Perform hit testing using the viewer as origin.
  this.hitTestSource = await this.**_session_**.requestHitTestSource({ space: this.viewerSpace });

  // ...
}

and it doesn't work, it throws the onNoXRDevice exception.

The functional code, found in step-04 folder is the following:

// Setup an XRReferenceSpace using the "local" coordinate system.
this.localReferenceSpace = await this.**_xrSession_**.requestReferenceSpace('local');

// Create another XRReferenceSpace that has the viewer as the origin.
this.viewerSpace = await this.**_xrSession_**.requestReferenceSpace('viewer');
// Perform hit testing using the viewer as origin.
this.hitTestSource = await this.**_xrSession_**.requestHitTestSource({ space: this.viewerSpace });
@devbridie devbridie self-assigned this Jul 29, 2021
@devbridie
Copy link
Member

Thanks for the catch! I can't immediately update the website at the moment (colleagues are in a far-off timezone), but the patch is waiting for submission. Thanks for bringing this up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants